Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SSH Tunnel functionality #81

Merged
merged 12 commits into from
Jul 5, 2021
Merged

feat: SSH Tunnel functionality #81

merged 12 commits into from
Jul 5, 2021

Conversation

digitalgopnik
Copy link
Contributor

@digitalgopnik digitalgopnik commented Jul 4, 2021 •
edited
Loading

Uses ssh2-promise for tunnel-functionality:

See also: ssh2-promise on github

  • Fixed also lint-error in not related (src/renderer/scss/themes/dark-theme.scss) - hopefully that's ok in this case. Otherwise pipelines will fail.

Tested with cases:

  • local mariadb (with and without ssl)
  • local postgres (without ssl)
  • ssh mariadb (without ssl) - with ssh-password | ssh-private-key
  • ssh postgres (without ssl - with ssh-password | ssh-private-key

@digitalgopnik digitalgopnik changed the title SSH Tunnel functionality feat: SSH Tunnel functionality Jul 4, 2021
@Fabio286 Fabio286 added the enhancement 🚀 New feature or request label Jul 4, 2021
@Fabio286 Fabio286 requested review from Fabio286 and removed request for Fabio286 July 4, 2021 20:37
@Fabio286
Copy link
Member

Fabio286 commented Jul 5, 2021

Hello @digitalgopnik ,
Infinitely thank you for your contribution!
Everything seems to be working fine.

@Fabio286 Fabio286 merged commit 1801bef into antares-sql:master Jul 5, 2021
@digitalgopnik
Copy link
Contributor Author

Great! :) You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digitalgopnik @Fabio286